findRelease() assumes usage is only for kubeseal

[rgee0]

This is loosely related to #874 and is extant in the current CLI version.

Expected Behaviour

If a faas-cli version check fails the error message that bubbles up to the user should be specific to faas-cli

Current Behaviour

Due to https://github.com/openfaas/faas-cli/blob/master/commands/cloud.go#L194 if a faas-cli version check fails due to a zero length location header the error message returned to the user will refer to kubeseal.

Why do you need this?

Clarity for the user

Are you a GitHub Sponsor (Yes/No?)

Check at: https://github.com/sponsors/openfaas

• Yes
• No

List All Possible Solutions and Workarounds

Swap out the string literal that refers to the tool name and use the incoming url value instead

Which Solution Do You Recommend?

Swap out the string literal that refers to the tool name and use the incoming url value instead

Steps to Reproduce (for bugs)

Difficult as it requires the specific error condition to be forced. Its easier understood through code inspection.

This call:

faas-cli/commands/version.go

Line 69 in d08553e

latest, err := findRelease(releases)

Reaches:

faas-cli/commands/cloud.go

Line 194 in d08553e

func findRelease(url string) (string, error) {

which returns:

faas-cli/commands/cloud.go

Line 219 in d08553e

return "", fmt.Errorf("unable to determine release of kubeseal")

Context

This is something I spotted while working on #874 and is more of a consideration if #874 doesn't get merged. In any event id suggest findReleases() should be made more generic.

Your Environment

• FaaS-CLI version ( Full output from: faas-cli version ):

• Docker version ( Full output from: docker version ):

• Are you using Docker Swarm (FaaS-swarm ) or Kubernetes (FaaS-netes)?

• Operating System and version (e.g. Linux, Windows, MacOS):

• Link to your project or a code example to reproduce issue:

[alexellis]

Is there a package in arkade that we can vendor for this?

[rgee0]

Maybe:

https://github.com/alexellis/arkade/blob/7b7ade38cff998b68886fe7f1260d080e881383a/pkg/get/get.go#L181

[alexellis]

I've made the suggested change, thank you for looking into it