This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR will fix an issue where context.fail() did not return custom status codes even though context.status() was called.
Description
I modified the context.succeed() and context.fail() methods to return a default status code of 200 and 500, respectively.
When the callback method (cb) is invoked, it will check which status code to return by checking if it has been defined by the handler (i.e. this.statusCode !== undefined). Otherwise, it will return the default status code mentioned above.
Motivation and Context
Which issue(s) this PR fixes
Fixes #4
How Has This Been Tested?
I created a handler with the following snippet and got the expected status code and message.
Types of changes
Checklist:
git commit -s