Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Cannot read property push of undefined' after finalizing onboarding #126

Open
rdkelley opened this issue May 22, 2021 · 5 comments
Open
Labels
bug Something isn't working

Comments

@rdkelley
Copy link
Collaborator

screen_after_add_to_device

@rdkelley rdkelley added the bug Something isn't working label May 22, 2021
@krook
Copy link
Member

krook commented May 22, 2021

I've seen this in the context of the history object. Is that where you've already explored?

@rdkelley
Copy link
Collaborator Author

Yeah, I imagine it has something to do with history but haven't had the chance to troubleshoot it yet. I did refactor some of how history is used in the latest PR, so if we're lucky it might already be fixed in the staging deployment. I'm going to investigate more tomorrow.

@rdkelley
Copy link
Collaborator Author

Just tested -- this does not seem to be an issue in the current staging version, so I'm guessing the refactor of the history object in the latest PR fixed it. After we release v.0.8.0, we'll make sure that's accurate and close this issue.

@krook
Copy link
Member

krook commented May 24, 2021

Sounds good. Even if it's not fixed, I think it's less a functional problem than a simple UI/navigation inconvenience. And if we can't get to the root cause later, maybe we just update error handling to look for it and ignore.

@krook
Copy link
Member

krook commented Oct 2, 2021

Have we confirmed whether this has indeed been fixed @rdkelley?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants