Update the Support Windows spreadsheet #199
Comments
|
@BbrSofiane I'll take care of this before the Olive branch cut. Can you create & add an @nedbat FYI |
|
@kdmccormick, just checking: can this be closed? |
|
@arbrandes It cannot, sorry. |
|
Unfortunately, I don't have time to do this, so I'm unassigning myself. |
|
the python code set up bars for versions of mongodb and the yml doesn't have new info for new version just setup parameters |
|
@datamatrixnull are you a bot? |
|
no, i'm considering fixing this to get an interview for your company
…On Mon, Mar 20, 2023 at 5:12 PM Kyle McCormick ***@***.***> wrote:
@datamatrixnull <https://github.com/datamatrixnull> are you a bot?
—
Reply to this email directly, view it on GitHub
<#199 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6NBCZRSG5JUZSMP5XPYON3W5BQVRANCNFSM6AAAAAAQKT27I4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@datamatrixnull Sorry about that. I had trouble making sense of your comment, and your account is new, so I assumed wrong. Let us know if there is any way we can help you get started. |
|
ok so i figure you're trying to update fields from the yml to the python
code to generate javascript code that can populate the excel file, what i
don't get is why the fields on the yml look more like variables for using
the application rather than the versions that's there on the python field.
…On Mon, Mar 20, 2023 at 5:25 PM Kyle McCormick ***@***.***> wrote:
@datamatrixnull <https://github.com/datamatrixnull> Sorry about that. I
had trouble making sense of your comment, and your account is new, so I
assumed wrong. Let us know if there is any way we can help you get started.
—
Reply to this email directly, view it on GitHub
<#199 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6NBCZQ43GHIC5JEZKQSN3LW5BSF5ANCNFSM6AAAAAAQKT27I4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Good question. The YML file holds the default settings for Tutor, which is our supported installation method. The master branch of Tutor installs the current supported version of Open edX. Most of those settings (like PREVIEW_LMS_HOST) area going to be irrelevant for this spreadsheet. The ones that are relevant are the _VERSION ones. We would like to use those various default _VERSION variables as input to barcalendar.py, so that we no longer need to hard code the current default versions. The YML file is actually a Jina2 template, allowing some of the defaults to be templated based on other defaults. I don't believe the spreadsheet will need any of the templated defaults, though. |
|
sounds like this is something that can only be fixed in house
…On Mon, Mar 20, 2023 at 5:40 PM Kyle McCormick ***@***.***> wrote:
Good question. The YML file holds the default settings for Tutor
<https://github.com/overhangio/tutor>, which is our supported
installation method. The master branch of Tutor installs the current
supported version of Open edX.
Most of those settings (like PREVIEW_LMS_HOST) area going to be irrelevant
for this spreadsheet. The ones that are relevant are the _VERSION ones. We
would like to use those various default _VERSION variables as input to
barcalendar.py, so that we no longer need to hard code the current
default versions
<https://github.com/openedx/repo-tools/blob/master/barcalendar.py#L247-L259>
.
The YML file is actually a Jina2 template, allowing some of the defaults
to be templated based on other defaults
<https://github.com/overhangio/tutor/blob/fa9e86e188f0a70b84f8b688e83a32a65b7bea10/tutor/templates/config/defaults.yml#L13>.
I don't believe the spreadsheet will need any of the templated defaults,
though.
—
Reply to this email directly, view it on GitHub
<#199 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6NBCZVZ3472ZPXGVXOKNHLW5BT7DANCNFSM6AAAAAAQKT27I4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
We're an open source project. The house is open! The variables that we can use from the YML file are:
The remaining versions (django, ubuntu, ruby, node) would take some refactoring to pull in. I could break those into a separate issue, though, if you were interested in starting with just these five. |
|
okay will look into it
…On Mon, Mar 20, 2023 at 5:57 PM Kyle McCormick ***@***.***> wrote:
We're an open source project. The house is open!
The variables that we can use from the YML file are:
- DOCKER_IMAGE_ELASTICSEARCH
- DOCKER_IMAGE_MONGODB
- DOCKER_IMAGE_MYSQL
- DOCKER_IMAGE_REDIS
- OPENEDX_COMMON_VERSION
The remaining versions (django, ubuntu, ruby, node) would take some
refactoring to pull in. I could break those into a separate issue, though,
if you were interested in starting with just these five.
—
Reply to this email directly, view it on GitHub
<#199 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6NBCZURGF6KLYLUQTBEHY3W5BV57ANCNFSM6AAAAAAQKT27I4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I saw there wasn't much activity on this issue, and figured it might not take too long, so I took a first pass at it here. Happy to edit or make any changes. |
|
Nice, thanks Mimmy! Once your CLA goes through we'll make sure someone reviews and merges your PR. |
|
The PR is now merged. |
github-project-automation
bot
moved this from Backlog
to Done
in Build-Test-Release Working Group
|
PR was: openedx/repo-tools#414 |
The spreadsheet: https://docs.google.com/spreadsheets/d/11DheEtMDGrbA9hsUvZ2SEd4Cc8CaC4mAfoV8SVaLBGI/edit#gid=195838733
The code that generates it: https://github.com/openedx/repo-tools/blob/master/barcalendar.py
The data we should use to update it: https://github.com/overhangio/tutor/blob/master/tutor/templates/config/defaults.yml
Acceptance Criteria
The text was updated successfully, but these errors were encountered: