Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serialize query_context as json for redability #828

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented May 24, 2024

Description

This PR serializes the query_context field as YAML for better readability

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 24, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bmtcril
Copy link
Contributor

bmtcril commented May 24, 2024

This errors for me with {'query_context': ['Not a valid string.']} for many if not all assets

@Ian2012 Ian2012 force-pushed the cag/query-context branch 2 times, most recently from 887a3e9 to cb15769 Compare May 27, 2024 15:49
@Ian2012 Ian2012 force-pushed the cag/query-context branch from cb15769 to 714e660 Compare May 27, 2024 15:57
@Ian2012 Ian2012 merged commit a81de2a into main May 27, 2024
9 checks passed
@Ian2012 Ian2012 deleted the cag/query-context branch May 27, 2024 18:37
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants