Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use enrolled date if last visited is not set #823

Merged

Conversation

saraburns1
Copy link
Contributor

Change SQL to user greater of enrolled at date or last visited - 'last visited' defaults to 1970/1/1 on creation.

Closes: openedx/platform-plugin-aspects#55

@openedx-webhooks
Copy link

Thanks for the pull request, @saraburns1! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 23, 2024
@saraburns1 saraburns1 requested review from bmtcril and Ian2012 May 23, 2024 15:18
@bmtcril
Copy link
Contributor

bmtcril commented May 23, 2024

CLA check is incoming, should pass later today!

@saraburns1 saraburns1 closed this May 23, 2024
@saraburns1 saraburns1 reopened this May 23, 2024
@Ian2012 Ian2012 merged commit 48adc7b into openedx:main May 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: Last visit date in reports defaults to epoch 0 (1970-01-01)
4 participants