Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Removing custom Superset assets #153

Open
bmtcril opened this issue Jul 6, 2023 · 5 comments
Open

bug: Removing custom Superset assets #153

bmtcril opened this issue Jul 6, 2023 · 5 comments
Assignees
Labels

Comments

@bmtcril
Copy link
Contributor

bmtcril commented Jul 6, 2023

In testing #107 , I created a custom superset row level policy and jinja filter. Upon turning off my test plugin and removing it, the jinja filter we removed from the python file but the security policy remained. This causes all queries on the filtered tables to fail.

I had to manually remove the row level security policy from the admin ui. If we can't automate removing these, which I suspect would be a huge effort, we should document the steps needed to deal with this issue.

@Ian2012
Copy link
Contributor

Ian2012 commented Jul 7, 2023

Maybe we want it to be optional, like a drop command or cleanup superset and cleanup clickhouse, so we don't have to manually drop the tables or the data from clickhouse, nor manually delete the assets for superset.

This way, in already running installations with modifications we can sync dashboard changes without breaking anything.

@Ian2012
Copy link
Contributor

Ian2012 commented Jul 25, 2023

The superset constraints are complex enough and this work impact it's not really valuable at this stage of the project.

We will consider this issue stale

@Ian2012 Ian2012 added stale and removed aspects v1 labels Jul 25, 2023
@Ian2012 Ian2012 self-assigned this Feb 23, 2024
@Ian2012
Copy link
Contributor

Ian2012 commented Apr 10, 2024

@bmtcril We can start using the tagging system with tags for all Aspects created assets, allowing us to remove all non-Aspects assets. However, only charts, dashboards, and saved queries can be tagged.

@bmtcril
Copy link
Contributor Author

bmtcril commented Apr 11, 2024

What do you think about tagging assets with their language (and a special tag for the un-localized "original" assets), and the Aspects version number they were created with? Then we could clean up things that a) were orphaned from earlier versions or b) untagged, meaning they were created manually with different command line switches. We could also let operators tag assets with something like "keep" so they never get cleaned up.

@Ian2012
Copy link
Contributor

Ian2012 commented Apr 11, 2024

I had in mind the tag for the language. The idea for the Aspects version number should help clean up known orphaned assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants