Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openedx/tutor-contrib-aspects
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c5008c2b5fe4459bc638feb204b775c7efe61e50
Choose a base ref
..
head repository: openedx/tutor-contrib-aspects
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e0fbb2387298634599d915db5984d084e49f7038
Choose a head ref
4 changes: 2 additions & 2 deletions .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
@@ -77,7 +77,7 @@ jobs:
make extract_translations
tutor local do import-assets
- name: Performance metrics
run: tutor local do performance-metrics
run: tutor local do performance-metrics --fail_on_error
- name: Tutor stop
run: tutor local stop

@@ -229,7 +229,7 @@ jobs:
make extract_translations
tutor k8s do import-assets
- name: Performance metrics
run: tutor k8s do performance-metrics
run: tutor k8s do performance-metrics --fail_on_error
- name: Check failure logs
if: failure()
run: |
Original file line number Diff line number Diff line change
@@ -193,6 +193,7 @@ def measure_chart(slice, query_context, fail_on_error):
raise query["error"]
except Exception as e:
logger.error(f"Error fetching slice data: {slice}. Error: {e}")
print(query_context)
if fail_on_error:
raise e
return
Original file line number Diff line number Diff line change
@@ -31,7 +31,8 @@ with
fss.grade_bucket as grade_bucket,
fss.username as username,
fss.name as name,
fss.email as email
fss.email as email,
fss.enrolled_at as enrolled_at
from {{DBT_PROFILE_TARGET_DATABASE}}.fact_student_status fss
where
1=1
@@ -53,7 +54,7 @@ select
fss.name as name,
fss.email as email,
fes.max_emission_time as emission_time,
let.last_visited as last_visited
GREATEST(let.last_visited, fss.enrolled_at) as last_visited
from student_status fss
left join
enrollment_status fes