[Product Pull Request] fix: Fix rows counter in the Edit Grade modal window

[jmakowski1123]

For Contributing Author:

This is the Primary Product Ticket for the following community contribution: Make course description editable in certificates

Checklist prior to undergoing Product Review:

The following information is required in order for Product Managers to be able to review your pull request:

• Explanation of the problem being solved
• Description of how users will be impacted, and which users will be impacted
• Screenshots or video showing the functionality or fix, before and after
• Reproduction steps and/or testing steps

Only if necessary:

• If necessary, links to corresponding configuration changes
• If necessary, links to corresponding enablement changes, particularly waffle/toggle status details

Related PRs

• fix: Fix rows counter in the Edit Grade modal window frontend-app-gradebook#310
• fix: Fix rows counter in the Edit Grade modal window (olive branch) frontend-app-gradebook#311

For Product Manager doing the review:

What criteria should be analyzed from Product to approve a PR?

• The problem being solved by the feature or fix is clear.
• There is clarity on how the change or fix will impact the end user.
• It is clear that the change will not negatively impact users or other areas of the platform.
• The change is implemented comprehensively.
• Any changes to UI use the current, standard Paragon Design System: https://paragon-openedx.netlify.app/

[github-actions]

Thanks for your submission, @openedx/open-edx-project-managers will review shortly.

[jmakowski1123]

Original information from the PR:

TL;DR - The problem was in the rows counter in the Edit Grades modal window. First digit - number of lines excluding the last line with the form. Second digit - grades data. And our proposal is to include last row with form to common counting

What changed?

FYI: @openedx/content-aurora

[jmakowski1123]

@spencertiberi This is a set of PRs to fix a bug in the grading modal. It seems pretty straightforward to me, but let me know if you need or want further information before giving it a product review. Since there are multiple PRs associated with the fix, I've created this Product Feature ticket to serve as a Master ticket, so you don't have to go into each separate PR. Once you've completed your review, leave a comment here in this Master ticket that the review is done!

[mphilbrick211]

@spencertiberi @ProductRyan just checking in to see if there's an update on the product review side?

[Daniel-hershel]

Hi everyone, I'm Daniel the new Product Manager with the Aurora team. I'll be taking over the product review responsibility for Aurora from Ryan. This PR looks good to me, thanks for the contribution!

[mphilbrick211]

Thanks @Daniel-hershel - just confirming that product review is complete on both: openedx/frontend-app-gradebook#310 and openedx/frontend-app-gradebook#311

[Daniel-hershel]

Hi @mphilbrick211 , sorry I didn't realize there were two here, but they look the same to me from a product/user experience perspective. Am I missing anything that delineates the two? Thanks!

[mphilbrick211]

Hi @Daniel-hershel - looks like one is Olive branch-specific.

[Daniel-hershel]

Can confirm this has completed product review for both tickets associated with this issue

[sarina]

Closing as this is marked "Shipped" on the PR board 🎉