Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Pull Request] fix: save scroll position on exit from video xblock fullscreen mode #226

Closed
2 of 12 tasks
jmakowski1123 opened this issue Feb 13, 2023 · 3 comments
Closed
2 of 12 tasks

Comments

@jmakowski1123
Copy link

jmakowski1123 commented Feb 13, 2023

For Contributing Author:

This is the Primary Product Ticket for the following community contribution: Fix the bug that when exiting a full-screen video, the browser does not return to the correct scroll position.

Checklist prior to undergoing Product Review:

The following information is required in order for Product Managers to be able to review your pull request:

  • Explanation of the problem being solved
  • Description of how users will be impacted, and which users will be impacted
  • Screenshots or video showing the functionality or fix, before and after
  • Reproduction steps and/or testing steps

Only if necessary:

  • If necessary, links to corresponding configuration changes
  • If necessary, links to corresponding enablement changes, particularly waffle/toggle status details

Related PRs

master

nutmeg

maple

For Product Manager doing the review:

What criteria should be analyzed from Product to approve a PR?

  • The problem being solved by the feature or fix is clear.
  • There is clarity on how the change or fix will impact the end user.
  • It is clear that the change will not negatively impact users or other areas of the platform.
  • The change is implemented comprehensively.
  • Any changes to UI use the current, standard Paragon Design System: https://paragon-openedx.netlify.app/
@github-actions
Copy link

Thanks for your submission, @openedx/open-edx-project-managers will review shortly.

@jmakowski1123 jmakowski1123 moved this to Community Contributions in Open edX Roadmap Feb 13, 2023
@jmakowski1123 jmakowski1123 changed the title [Community Contribution] fix: save scroll position on exit from video xblock fullscreen mode [Product Pull Request] fix: save scroll position on exit from video xblock fullscreen mode Feb 13, 2023
@jmakowski1123
Copy link
Author

close in favor of tracking here: #229

@itsjeyd
Copy link

itsjeyd commented Feb 15, 2023

Closing.

@itsjeyd itsjeyd closed this as completed Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants