Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ref support in container #2452

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

ahtesham-quraish
Copy link
Contributor

Description:
Add react ref support in container component

related to : VAN-1537

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit ad33f55
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64b63f4e8e2497000821b5ce
😎 Deploy Preview https://deploy-preview-2452--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Description:
Add ref support in container component
VAN-1537
@ahtesham-quraish ahtesham-quraish force-pushed the ahtesham/VAN-1537/add-ref-in-container branch from 461cc18 to ad33f55 Compare July 18, 2023 07:29
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (21ff444) 91.38% compared to head (ad33f55) 91.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2452   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         234      234           
  Lines        4157     4157           
  Branches     1001     1001           
=======================================
  Hits         3799     3799           
  Misses        351      351           
  Partials        7        7           
Impacted Files Coverage Δ
src/Container/index.jsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@viktorrusakov viktorrusakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@viktorrusakov viktorrusakov merged commit d55001f into master Jul 18, 2023
9 checks passed
@viktorrusakov viktorrusakov deleted the ahtesham/VAN-1537/add-ref-in-container branch July 18, 2023 09:02
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.45.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

pedromartello pushed a commit to hammerlabs-net/paragon that referenced this pull request Aug 10, 2023
Description:
Add ref support in container component
VAN-1537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants