-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add-newsstand-icon #3275
feat: add-newsstand-icon #3275
Conversation
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this using the docs preview generated for this PR.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
User-facing strings are extracted for translationN/A
783a10d
to
207edcb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3275 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 249 249
Lines 4441 4441
Branches 1014 1014
=======================================
Hits 4144 4144
Misses 294 294
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Braden MacDonald <[email protected]>
207edcb
to
346787d
Compare
🎉 This PR is included in version 22.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR adds the
newsstand
icon frommaterial-symbols
to Paragon.The icon was sourced from here:
Deploy Preview
https://deploy-preview-3275--paragon-openedx.netlify.app/foundations/icons/
Check the
newsstand
iconMerge Checklist
example
app?Post-merge Checklist