-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form.Autosuggest Accessibility #2410
Comments
Great writeup here! I'm thinking it might make sense to split this up into a couple issues:
|
@MaxFrank13 This is a good succinct summary of the accessibility issues. Just a couple of additional details:
|
Regarding focus behavior, I refer to the linked articles outlining or demonstrating accessible autosuggest requirements. Additional background re aria-activedescendant: this attribute is intended to be a kind of "sub-focus". So a parent item has focus, but you're really working on some kind of child item. The two examples that come to mind are grids (parent has focus, active cell has aria-activedescendant) and comboboxes (input has focus, menu items have activedescendant.). One thing to know here is that there are sometimes two ways to implement theses common patterns; you can make a grid where the cell being modified has focus, or where some control within that cell has focus. Aria-activedescendant is intended to guide a screen magnifier so it can keep the thing you're working on in the magnification frame at all times. I'm not entirely sure of the level of support across accessibility tools. Regarding aria-live: be aware that testing with VoiceOver on Mac OS with Chrome may not work as expected, particularly with aria-live. Instead use VoiceOver with Safari. This is a longstanding issue; I don't think Apple feels strongly motivated to fix Chrome compatibility bugs. |
Should be fixed by now. If not can reopen. |
Improvements
There are a number of adjustments that can be made to the
Form.Autosuggest
component to make it more accessible. Some of these adjustments are relatively trivial and involve simply updating the attributes on a few of the HTML elements. However, other changes will require a bit of refactoring around the HTML structure, especially with regards to how labels are associated with the<input>
element.Resources
Accessible Autocomplete examples
Anatomy of an Accessible Auto Suggest
Best practices for the accessibility of an autocompletion component
Moving forward
Aperture team has plans to address these issues over time, but the work has not yet been assigned so we welcome any assistance others can provide. If any updates are made regarding the accessibility of the
Form.Autosuggest
component, please reference this issue and don't hesitate to reach out to @openedx/2u-aperture.Tasks
The text was updated successfully, but these errors were encountered: