-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] docs: add info about xs min-width #2400
[BD-46] docs: add info about xs min-width #2400
Conversation
Thanks for the pull request, @monteri! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2400 +/- ##
=======================================
Coverage 91.38% 91.38%
=======================================
Files 234 234
Lines 4157 4157
Branches 1001 1001
=======================================
Hits 3799 3799
Misses 351 351
Partials 7 7 ☔ View full report in Codecov by Sentry. |
@PKulkoRaccoonGang @monteri just curious - was there a github issue for this? I can't seem to find one. Feels a little weird to add this question mark, can't we just write |
@viktorrusakov Yes, there is an issue #2375, we discussed on the meeting to implement tooltip in order to specify which min breakpoint is supported in Paragon. Since this breakpoint is not used in the code then we decided to put it in the tooltip as info. |
@monteri I see, thanks! LGTM. |
@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 20.45.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* docs: add info about xs min-width * docs: update responsive v2 --------- Co-authored-by: monteri <lansevermore>
Description
Add question mark icon and tooltip with text for the
xs
min-width breakpointDeploy Preview
https://deploy-preview-2400--paragon-openedx.netlify.app/
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist