Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] docs: add info about xs min-width #2400

Conversation

monteri
Copy link
Contributor

@monteri monteri commented Jun 23, 2023

Description

Add question mark icon and tooltip with text for the xs min-width breakpoint

Deploy Preview

https://deploy-preview-2400--paragon-openedx.netlify.app/

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Jun 23, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @monteri!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Jun 23, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2f2633e
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64a2d0102516ef0008b113f2
😎 Deploy Preview https://deploy-preview-2400--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (85685f6) 91.38% compared to head (2f2633e) 91.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2400   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         234      234           
  Lines        4157     4157           
  Branches     1001     1001           
=======================================
  Hits         3799     3799           
  Misses        351      351           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viktorrusakov
Copy link
Contributor

@PKulkoRaccoonGang @monteri just curious - was there a github issue for this? I can't seem to find one. Feels a little weird to add this question mark, can't we just write 320px in min width column?

@monteri
Copy link
Contributor Author

monteri commented Jul 14, 2023

@viktorrusakov Yes, there is an issue #2375, we discussed on the meeting to implement tooltip in order to specify which min breakpoint is supported in Paragon. Since this breakpoint is not used in the code then we decided to put it in the tooltip as info.

@viktorrusakov
Copy link
Contributor

@monteri I see, thanks! LGTM.

@viktorrusakov viktorrusakov merged commit fae10e1 into openedx:master Jul 14, 2023
9 checks passed
@openedx-webhooks
Copy link

@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.45.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

pedromartello pushed a commit to hammerlabs-net/paragon that referenced this pull request Aug 10, 2023
* docs: add info about xs min-width

* docs: update responsive v2

---------

Co-authored-by: monteri <lansevermore>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[paragon-openedx.netlify.app] Feedback (on /foundations/responsive)
5 participants