Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect icons fill #2388

Closed
2 tasks
PKulkoRaccoonGang opened this issue Jun 21, 2023 · 6 comments
Closed
2 tasks

Incorrect icons fill #2388

PKulkoRaccoonGang opened this issue Jun 21, 2023 · 6 comments
Assignees
Labels
bug Report of or fix for something that isn't working as intended raccoon-gang

Comments

@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented Jun 21, 2023

At the moment, Paragon provides a large number of icons for consumers. When using WarningFilled, @KristinAoki noticed that the icon was missing a color fill. After checking some Paragon icons, it was seen that this problem is not isolated and can occur in other icons.

image

  • We will look for non-Alert usages of the above icons and document them.
  • We will fix these icons to look as they should but in black/white.
  • Verify the Alert styling, etc. works correctly with the updated icons.
  • [consideration] Check in with an owning team using one of the these icons to QA.

Tasks

@PKulkoRaccoonGang PKulkoRaccoonGang added the bug Report of or fix for something that isn't working as intended label Jun 21, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title Incorrect icon fill Incorrect icons fill Jun 21, 2023
@adamstankiewicz
Copy link
Member

adamstankiewicz commented Jun 23, 2023

Affected icons:

image

@adamstankiewicz
Copy link
Member

  • We will look for non-Alert usages of the above icons and document them.
  • We will fix these icons to look as they should but in black/white.
  • Verify the Alert styling, etc. works correctly with the updated icons.
  • (consideration] Check in with an owning team using one of the these icons to QA.

@adamstankiewicz adamstankiewicz moved this from Backlog to To Do in Paragon Working Group Jun 23, 2023
@monteri monteri self-assigned this Jun 27, 2023
@monteri monteri moved this from To Do to In progress in Paragon Working Group Jul 4, 2023
@monteri monteri moved this from In progress to In review in Paragon Working Group Jul 14, 2023
@adamstankiewicz
Copy link
Member

@monteri @PKulkoRaccoonGang I believe the next step here is to try to get the impacted icons running in at least one of these example non-Alert usages. The quickest way might be to just temporarily override everything in those MFE's src/index.jsx file's APP_READY callback function to render just the necessary icon(s) as a quick sanity check (to avoid needing to figure out how to get to those specific usages in each MFE's user flows).

Ideally, we'd see the before (solid gray icons) initially, and (after) then once Paragon is upgraded in the MFE to account for the icons fix, the icons should look semantically correct.

@monteri monteri moved this from In review to To Do in Paragon Working Group Jul 25, 2023
@PKulkoRaccoonGang
Copy link
Contributor Author

PKulkoRaccoonGang commented Aug 3, 2023

@adamstankiewicz I tested the corrected icons in the MFE Course Authoring. Each screenshot shows the version of the Paragon release being tested. As we can see the icons are now displayed correctly! 👍

image
image

@PKulkoRaccoonGang PKulkoRaccoonGang moved this from To Do to In progress in Paragon Working Group Aug 3, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from In progress to In review in Paragon Working Group Aug 3, 2023
@adamstankiewicz
Copy link
Member

Thanks for verifying, @PKulkoRaccoonGang! Closing this issue.

@github-project-automation github-project-automation bot moved this from In review to Done in Paragon Working Group Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended raccoon-gang
Projects
Status: Done
Development

No branches or pull requests

3 participants