-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add complete example of infrastructure with aws #87
Conversation
Thanks for the pull request, @Henrrypg! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi, @MoisesGSalas @jfavellar90 Can you look at this? |
@gabor-boros could you also take a look at this? |
@bradenmacdonald Absolutely! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review is a bit delayed, sorry about that. I was thinking about this for a while now.
Overall, I think this PR is good as is -- after bumping the modules and providers to their latest version if applicable --, so I'm approving the changes here.
Besides that, this PR and the conversations we had in the working group during the meetings made me think if the file/directory structure is pointing towards the direction we want, i.e., having modules that can be used by community members in their Terraform scripts.
I would not like to block this PR from being merged on something that changed in the meantime, however, could you please open a GitHub issue as a "follow-up" to refactor the changes introduced here? I'll come up/propose a structure that in my opinion could be good, though that will be still up to the working group if we agree on that or not.
Add Terraform Configuration for Basic AWS EKS Cluster
This PR introduces a set of Terraform files that provide a basic example or starting point for deploying a Kubernetes cluster on AWS using Elastic Kubernetes Service (EKS). The configuration includes:
Key Files and Features:
eks.tf
: Core infrastructure setup for the EKS cluster.vpc.tf
: Core infrastructure setup for the VPC.variables.tf
: Parameters that allow customization of the cluster, such as instance types, cluster size, and networking options.outputs.tf
: Exposes key outputs like cluster name and endpoint.provider.tf
: Configures the AWS provider and region.How to use:
variables.tf
or use avalues.auto.tfvars.json
file to adjust parameters like AWS region, instance types, and node group settings.terraform apply
to deploy the infrastructure.This setup serves as a base or example for future enhancements and can be expanded with additional features or modules as needed.