-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for tutor 19 #140
chore: add support for tutor 19 #140
Conversation
Thanks for the pull request, @kaustavb12! This repository is currently maintained by @openedx/openedx-k8s-harmony-maintainers. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaustavb12 have you tested if the harmony plugin can handle instances created by tutor 19?
Yes. This sandbox instance(private-ref) was created with this PR branch along with tutor 19. Please take a look. |
Seems pretty straight forward. Is there something we should be wary of after Tutor removed ES from core? |
I think ES related config and code should eventually be removed from Harmony. We also need to be careful about version compatibility, i.e. upto what version of Harmony would support older Open edX releases with ES, etc. But for this PR, my goal was to simply make sure we are able to correctly spin up Sumac instances using Harmony. I simply set |
Can you please help out with moving this PR forward. cc. @bradenmacdonald |
Thanks @bradenmacdonald. |
Description
Adds support for tutor 19.
Other information
Private ref : BB-9353