Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing cert-manager invalid value #126

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jfavellar90
Copy link
Contributor

The cert-manager validations are strict so it won't accept un-supported values in the chart configuration. This PR removes the email (it is not supported in the current chart version) value from the cert-manager configuration to prevent failures in installing the Harmony chart.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 9, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @jfavellar90!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-k8s-harmony-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@jfavellar90 jfavellar90 force-pushed the Jhony/fix_email_cert_manager branch from 938c6c8 to 79fcb47 Compare December 9, 2024 18:32
@jfavellar90 jfavellar90 requested a review from Ian2012 December 9, 2024 18:48
@jfavellar90 jfavellar90 merged commit 8c54a3b into main Dec 9, 2024
3 checks passed
@jfavellar90 jfavellar90 deleted the Jhony/fix_email_cert_manager branch December 9, 2024 19:31
@gabor-boros
Copy link
Contributor

@jfavellar90 & @Ian2012 The cert-manager email value was in use. https://github.com/openedx/openedx-k8s-harmony/blob/main/charts/harmony-chart/templates/issuer.yaml#L9C5-L9C54

Removing that value means that we won't be able to create let's encrypt certificates as that value is mandatory: https://cert-manager.io/docs/tutorials/acme/nginx-ingress/#step-6---configure-a-lets-encrypt-issuer

@jfavellar90
Copy link
Contributor Author

@jfavellar90 & @Ian2012 The cert-manager email value was in use. https://github.com/openedx/openedx-k8s-harmony/blob/main/charts/harmony-chart/templates/issuer.yaml#L9C5-L9C54

Removing that value means that we won't be able to create let's encrypt certificates as that value is mandatory: https://cert-manager.io/docs/tutorials/acme/nginx-ingress/#step-6---configure-a-lets-encrypt-issuer

@gabor-boros thanks for fixing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants