Change course and library keys to use OpenedX, DemoCourse, etc #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarina
approved these changes
Feb 8, 2024
|
|
per trademark guidelines
to match style of org and course number (OpenedX+DemoX)
kdmccormick
changed the title
kdmccormick
changed the title
|
@sarina With us using OpenedX now, it was driving me crazy that everything besides demo_course was camel case, so I've pushed one last commit that changes the run from So now we have: Before
After
Any objections? |
|
@kdmccormick Overall I appreciate you as an engineer, so much. This attention to detail - and the need to make things right - exemplify this. Thank you for being you. Approved. |
kdmccormick
changed the base branch from
master
to
tcril/depr-automation-workflow
kdmccormick
changed the base branch from
tcril/depr-automation-workflow
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per convo in #49 (comment)
Before
After