Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: python3.11 support #100

Closed

Conversation

ichintanjoshi
Copy link
Contributor

Description

This PR contains changes for upgrading python 3.8 to python 3.11.
Changes include :-

  • Dependencies and version upgrades
  • Extra check for factorial function to get only integers
    • This is done because evaluator function in calc.py file will convert all numbers to float
    • And python 3.11 will not allow math.factorial to calculate float values and will raise an error ref
  • Removal of float numbers for factorial function tests (Same explanation as above)

Done as a part of this issue openedx/public-engineering#233

@openedx-webhooks
Copy link

Thanks for the pull request, @ichintanjoshi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 24, 2024
@openedx-webhooks
Copy link

@ichintanjoshi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@ichintanjoshi ichintanjoshi deleted the add-python3.11-support branch March 28, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants