Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package missing readme #39

Open
brian-smith-tcril opened this issue Aug 14, 2023 · 4 comments
Open

npm package missing readme #39

brian-smith-tcril opened this issue Aug 14, 2023 · 4 comments
Assignees

Comments

@brian-smith-tcril
Copy link
Contributor

image

@brian-smith-tcril
Copy link
Contributor Author

From what I've read it seems like npm might not support .rst readmes. Maybe we can generate a .md that links to the GH repo?

@OmarIthawi
Copy link
Member

I think it's a package.json configuration issue. I'll publish to pypi and get back to this.

@OmarIthawi
Copy link
Member

@brian-smith-tcril Based on my quick research, it looks like that npm doesn't support RST at all, while PyPi appears to support both RST and Markdown:

Popular packages such as React.js use Markdown: https://www.npmjs.com/package/react

Some Open edX packages uses Markdown as well such https://www.npmjs.com/package/@edx/paragon while others don't as you pointed out for frontend-build.

We have a couple of options:

  1. Use Markdown on all Open edX Nodej.s packages
  2. Use Placeholder README (my least favorite)
  3. Convert to Markdown on the fly (adds yet one more build step)

I'm leaning towards using Markdown at least until npmjs has support for RST.

@brian-smith-tcril
Copy link
Contributor Author

@OmarIthawi would you mind adding that comment to openedx/public-engineering#215 ? I brought this up in standup yesterday and people seemed to be OK with the placeholder idea, but I'm more than happy to re-open the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants