Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Prompt | Confirmation Alert Missing Before Deleting Section-Level Downloaded Videos #456

Closed
shafqat-muneer opened this issue Jun 11, 2024 · 0 comments · Fixed by #463
Closed

[iOS] Prompt | Confirmation Alert Missing Before Deleting Section-Level Downloaded Videos #456

shafqat-muneer opened this issue Jun 11, 2024 · 0 comments · Fixed by #463
Assignees
@forgotvas
Labels
bug Report of or fix for something that isn't working as intended

Comments

@shafqat-muneer
Copy link
Contributor

shafqat-muneer commented Jun 11, 2024 •
edited
Loading

No confirmation alert appears before deleting section-level downloaded videos.

Steps to reproduce

  1. Navigate to the videos section.
  2. Tap on download button from the section.
  3. Downloading will start.
  4. A green button will appear, indicating that the videos have been downloaded.
  5. Tap the green button.
  6. The videos will be deleted without a confirmation prompt.

Demo Video:

Simulator.Screen.Recording.-.iPhone.15.-.2024-06-11.at.15.44.08.mp4

Expected Behavior:

Ideally, a confirmation alert should appear before deleting videos, as users might accidentally tap the delete button.
@shafqat-muneer shafqat-muneer added the bug Report of or fix for something that isn't working as intended label Jun 11, 2024
@forgotvas forgotvas mentioned this issue Jun 13, 2024
Merged
@forgotvas forgotvas linked a pull request Jun 13, 2024 that will close this issue
[iOS] Prompt | Confirmation Alert Missing Before Deleting Section-Level Downloaded Videos #456 #463
Merged
volodymyr-chekyrta pushed a commit that referenced this issue Jun 20, 2024
@forgotvas
[iOS] Prompt | Confirmation Alert Missing Before Deleting Section-Lev…
5498a1c 
…el Downloaded Videos #456 (#463)

* fix: confirmation alert

* chore: changed string to localization

* chore: review required changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@forgotvas forgotvas

Labels
bug Report of or fix for something that isn't working as intended
Projects
None yet
Milestone
No milestone
2 participants
@forgotvas @shafqat-muneer