Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid frontend-platform import in Footer.jsx #398

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bradenmacdonald
Copy link
Contributor

I am working on some experimental changes to improve frontend-platform, and when modernizing the package.json exports field, I started seeing this error in the course authoring MFE:

Screenshot 2024-01-16 at 2 35 03 PM

According to the frontend-platform documentation, configuration functions like ensureConfig should always be imported from @edx/frontend-platform, not @edx/frontend-platform/config which is actually a "private" implementation file.

Currently, frontend-platform's package.json uses a legacy syntax that lets you import from any files you want within it, but when we modernize it to use the exports field to define the set of public exports, /config will presumably no longer work since it's not part of the public API.

So far, this is the only bad import I've found.

@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 16, 2024
@mphilbrick211
Copy link

@openedx/2u-fed-bom this is ready for review.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 20, 2024
@abdullahwaheed
Copy link
Contributor

@bradenmacdonald could you please rebase it with master so we can merge it

@bradenmacdonald
Copy link
Contributor Author

@abdullahwaheed Sure, done.

@mphilbrick211 mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 8, 2024
@abdullahwaheed abdullahwaheed merged commit a49b063 into openedx:master Mar 11, 2024
5 checks passed
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the fix-platform-import branch September 3, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants