fix: tinyMCELanguageSelectorPlugin error related to Button ID #991
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 67.77% 67.76% -0.01%
==========================================
Files 128 128
Lines 3230 3233 +3
Branches 937 937
==========================================
+ Hits 2189 2191 +2
- Misses 993 994 +1
Partials 48 48 ☔ View full report in Codecov by Sentry. |
| if (IN_REVIEW_STATUS.includes(courseRun.status) !== isCourseRunInReview) { | ||
| setTimeout(() => { | ||
| this.setState({ isCourseRunInReview: IN_REVIEW_STATUS.includes(courseRun.status) }); | ||
| }, 100); |
There was a problem hiding this comment.
this 0.1 value -- what was the reason for selecting this value?
There was a problem hiding this comment.
I tried random values for the timeout, i.e. 500, 200, 100, 50. It's minimum value at which this error no longer appears.
There was a problem hiding this comment.
That is from your local testing, I would suggest keeping the deployment environment in mind when deciding this.
There was a problem hiding this comment.
Hmm, maybe we can increase the timeout a bit, or let's try this out on staging first to check if the error still appears (cause I don't want to add unnecessary delay in rendering of review related fields)
Done, I've added the steps to reproduce this error locally, you can test it out on stage as well. |
AfaqShuaib09
force-pushed
the
afaq/prod-4210
branch
from
b974b5c
to
4cca100
Compare
Ah, it’s reproducible for me now, even after reloading the page. However it’s sort of flaky behavior, sometimes it appears on page refresh, and sometimes it doesn’t. Two days ago, it didn’t appear for me at all after refreshing the page. I’m not sure what the issue is. The PR above will resolve the error for the review state transition scenario. I think it would be better to ignore this error, as we did for support-tools |
This PR fixes the TinyMCE editor Language Selector
failed to find and set button ID in TinyMceLanguageSelectorPlugin after 3 attempts. It adds a0.1-sectimeout to prevent TinyMCE from appearing immediately after the state change, as the editor reloads afterward, causing it to disappear and triggering the error above.Error Reproduction Steps:
failed to find and set button ID in TinyMceLanguageSelectorPlugin after 3 attempts in the console log.