From 1bab888906435436e7bff57ba2a308a337da8ec3 Mon Sep 17 00:00:00 2001 From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com> Date: Mon, 9 Sep 2024 17:30:42 +0500 Subject: [PATCH 1/2] test: Remove support for Node 18 --- .github/workflows/validate.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index db5ad39ba3..f705e2f1c5 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -9,14 +9,11 @@ on: jobs: tests: runs-on: ubuntu-latest - strategy: - matrix: - node: [18, 20] steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v4 with: - node-version: ${{ matrix.node }} + node-version-file: '.nvmrc' - run: make validate.ci - name: Upload coverage uses: codecov/codecov-action@v4 From 1d2786754f76733f8aaff96712a1f8d774eab99d Mon Sep 17 00:00:00 2001 From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com> Date: Tue, 29 Oct 2024 14:01:10 +0500 Subject: [PATCH 2/2] chore: update code coverage artifact naming --- .github/workflows/validate.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index 0590f23024..8634743f6d 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -18,9 +18,7 @@ jobs: - name: Archive code coverage results uses: actions/upload-artifact@v4 with: - name: code-coverage-report-${{ matrix.node }} - # When we're only using Node 20, replace the line above with the following: - # name: code-coverage-report + name: code-coverage-report path: coverage/*.* coverage: runs-on: ubuntu-latest @@ -30,9 +28,7 @@ jobs: - name: Download code coverage results uses: actions/download-artifact@v4 with: - name: code-coverage-report-20 - # When we're only using Node 20, replace the line above with the following: - # name: code-coverage-report + name: code-coverage-report - name: Upload coverage uses: codecov/codecov-action@v4 with: