-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ugly appearance of the Start/Resume Course button at the top of the course outline #1585
fix: Ugly appearance of the Start/Resume Course button at the top of the course outline #1585
Conversation
…the course outline
Thanks for the pull request, @Lunyachek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1585 +/- ##
=======================================
Coverage 84.60% 84.60%
=======================================
Files 331 331
Lines 5656 5656
Branches 1357 1396 +39
=======================================
Hits 4785 4785
Misses 854 854
Partials 17 17 ☔ View full report in Codecov by Sentry. |
Hey @Lunyachek, thank you for this contribution! It looks like the changes are ready for review, so I'll update the status of this PR accordingly. Let me know if you were still planning on making further changes, though. |
Hi! No future changes are planned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
In the future, please also include a comment directly in the SCSS file explaining the intention behind the rules, so it's more clear for people stumbling across this in the future.
Fix: Improved Styling of the "Start/Resume Course" Button on Mobile Devices
Summary
On mobile devices, the "Start/Resume Course" button had an inconsistent and visually unappealing layout at the top of the course outline. This PR improves its alignment and spacing, ensuring a cleaner and more polished appearance.
Changes
Adjusted button positioning for better alignment on mobile screens.
Improved spacing and padding to enhance visual balance.
Before & After (Mobile)
Before:
![Снимок экрана 2025-02-11 в 18 41 45](https://private-user-images.githubusercontent.com/19806032/412085220-dcbc2e4f-d849-4862-b5fb-18d74cefb33e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTM5MzgsIm5iZiI6MTczOTYxMzYzOCwicGF0aCI6Ii8xOTgwNjAzMi80MTIwODUyMjAtZGNiYzJlNGYtZDg0OS00ODYyLWI1ZmItMThkNzRjZWZiMzNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDEwMDAzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBkMzg4ZTg2ODgwYmZiNjIwN2EzNjJjZmYzMTExM2RiNTQ0N2I4NDZlYzdlOTNlZGJiZDBiOWI1Yjg5Y2I2ODYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.-pMqbnI6BsU2xe27pSDYIULFAXXweLDqIqnRzEtYpuk)
After:
![Снимок экрана 2025-02-11 в 18 42 10](https://private-user-images.githubusercontent.com/19806032/412085380-8fd8d49b-3160-4fbc-82df-89b923ad9192.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTM5MzgsIm5iZiI6MTczOTYxMzYzOCwicGF0aCI6Ii8xOTgwNjAzMi80MTIwODUzODAtOGZkOGQ0OWItMzE2MC00ZmJjLTgyZGYtODliOTIzYWQ5MTkyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDEwMDAzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE2NmM4MWQ3MjVhMzI4OTEzY2MwODM5ZWYxNDgwNGI4N2JmYjZlNGFkZGM1N2E5NGYzZjQ4YjE2YmZkMDNhMjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.5jQoQKDuZoWRWJGYrFJuD_csF5fT7vv6V3I_axismSM)
Now, the button integrates more seamlessly with the course outline, improving the mobile user experience.