Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ugly appearance of the Start/Resume Course button at the top of the course outline #1585

Conversation

Lunyachek
Copy link
Contributor

Fix: Improved Styling of the "Start/Resume Course" Button on Mobile Devices

Summary

On mobile devices, the "Start/Resume Course" button had an inconsistent and visually unappealing layout at the top of the course outline. This PR improves its alignment and spacing, ensuring a cleaner and more polished appearance.

Changes

Adjusted button positioning for better alignment on mobile screens.
Improved spacing and padding to enhance visual balance.
Before & After (Mobile)

Before:
Снимок экрана 2025-02-11 в 18 41 45

After:
Снимок экрана 2025-02-11 в 18 42 10

Now, the button integrates more seamlessly with the course outline, improving the mobile user experience.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 11, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (9dc45e1) to head (ad2e69a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1585   +/-   ##
=======================================
  Coverage   84.60%   84.60%           
=======================================
  Files         331      331           
  Lines        5656     5656           
  Branches     1357     1396   +39     
=======================================
  Hits         4785     4785           
  Misses        854      854           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Feb 13, 2025

Hey @Lunyachek, thank you for this contribution! It looks like the changes are ready for review, so I'll update the status of this PR accordingly. Let me know if you were still planning on making further changes, though.

@itsjeyd itsjeyd requested a review from a team February 13, 2025 13:53
@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 13, 2025
@Lunyachek
Copy link
Contributor Author

Hey @Lunyachek, thank you for this contribution! It looks like the changes are ready for review, so I'll update the status of this PR accordingly. Let me know if you were still planning on making further changes, though.

Hi! No future changes are planned

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

In the future, please also include a comment directly in the SCSS file explaining the intention behind the rules, so it's more clear for people stumbling across this in the future.

@bradenmacdonald bradenmacdonald merged commit eef6b1e into openedx:master Feb 15, 2025
7 checks passed
@openedx-webhooks openedx-webhooks removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants