chore: make sure links point to MFE not legacy #1584
Conversation
now that the legacy profile and account pages have been removed, we need to make sure that all of the links point to the MFE URLs; we were relying on the legacy applications to do redirection before. FIXES: APER-3884 FIXES: openedx/public-engineering#71
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1584 +/- ##
=======================================
Coverage 84.60% 84.60%
=======================================
Files 331 331
Lines 5656 5656
Branches 1357 1396 +39
=======================================
Hits 4785 4785
+ Misses 854 852 -2
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry. |
| #!/bin/sh | ||
| if [ -z "$husky_skip_init" ]; then | ||
| debug () { | ||
| if [ "$HUSKY_DEBUG" = "1" ]; then | ||
| echo "husky (debug) - $1" | ||
| fi | ||
| } | ||
| echo "husky - DEPRECATED | ||
|
|
||
| readonly hook_name="$(basename "$0")" | ||
| debug "starting $hook_name..." | ||
| Please remove the following two lines from $0: | ||
|
|
||
| if [ "$HUSKY" = "0" ]; then | ||
| debug "HUSKY env variable is set to 0, skipping hook" | ||
| exit 0 | ||
| fi | ||
| #!/usr/bin/env sh | ||
| . \"\$(dirname -- \"\$0\")/_/husky.sh\" | ||
|
|
||
| if [ -f ~/.huskyrc ]; then | ||
| debug "sourcing ~/.huskyrc" | ||
| . ~/.huskyrc | ||
| fi | ||
|
|
||
| export readonly husky_skip_init=1 | ||
| sh -e "$0" "$@" | ||
| exitCode="$?" | ||
|
|
||
| if [ $exitCode != 0 ]; then | ||
| echo "husky - $hook_name hook exited with code $exitCode (error)" | ||
| fi | ||
|
|
||
| exit $exitCode | ||
| fi | ||
| They WILL FAIL in v10.0.0 | ||
| " |
There was a problem hiding this comment.
Can you explain the changes to this husky file? It doesn't appear related to the URL change
There was a problem hiding this comment.
I didn't make them. I asked JW and he said husky changes can happen automatically under some circumstances, but it might have been a weird PR making glitch. What's your take? should I revert this change?
There was a problem hiding this comment.
huh, I think this change might have been made by a pre-commit script. I have to get CC review on it anyway, so let's see what aurora says.
There was a problem hiding this comment.
oooh I didn't realize it was doing this. I've just seen husky dependency updates get auto-merged by Renovate, but I hadn't seen this before
|
thanks! @nsprenkle , the new CC system means I can't merge this myself, I believe, so I'll wait for you. |
Pull Request is not mergeable
|
I think this PR looks good, and I approved it, but GitHub is not letting me merge it. It's stuck on "Checking for the ability to merge automatically..." and also says "Pull Request is not mergeable", without explanation. |
now that the legacy profile and account pages have been removed, we need to make sure that all of the links point to the MFE URLs; we were relying on the legacy applications to do redirection before.
FIXES: APER-3884
FIXES: openedx/public-engineering#71