Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #280

Merged
merged 6 commits into from
Oct 2, 2023

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Jul 11, 2023

TIcket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17 along with react-test-renderer, react-helmet, @fortawesome/react-fontawesome & react-redux to respective compatible versions
  • Uninstalled unused package recompose.
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1c78589) 67.17% compared to head (5aa7635) 67.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   67.17%   67.17%           
=======================================
  Files          43       43           
  Lines         783      783           
  Branches      154      154           
=======================================
  Hits          526      526           
  Misses        249      249           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m marked this pull request as ready for review August 1, 2023 06:18
@abdullahwaheed abdullahwaheed merged commit b61a621 into master Oct 2, 2023
@abdullahwaheed abdullahwaheed deleted the mashal-m/react-upgrade-to-v17 branch October 2, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants