Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #427

Open
MaxFrank13 opened this issue Aug 19, 2024 · 2 comments
Open

Remove unused dependencies #427

MaxFrank13 opened this issue Aug 19, 2024 · 2 comments

Comments

@MaxFrank13
Copy link
Member

There are a handful of package dependencies that appear to be unused by the code in this repository. Some of these just need to be moved to devDependencies while others are not direct requirements and can at least be removed from the package.json. For example, the history package is used by frontend-platform, but not frontend-app-learner-dashboard. So when it's removed from Learner Dashboard package.json, it will only appear in package-lock under frontend-platform, but won't be a direct dependency for Learner Dashboard.

The below listed dependencies were chosen based on a simple search through frontend-app-learner-dashboard to see if they were utilized. Any packages that were not imported from or did not appear to be used in some other way are included in the list.

To assess for removal:

  • @redux-beacon/segment
  • @testing-library/user-event
  • dompurify
  • email-prop-type
  • file-saver
  • filesize
  • history
  • html-react-parser
  • react-pdf
  • redux-beacon
  • universal-cookie
  • whatwg-fetch

To move to devDependencies:

  • jest
  • jest-environment-jsdom
  • jest-when
@jciasenza
Copy link

I can take this issue @arbrandes

jciasenza added a commit to jciasenza/frontend-app-learner-dashboard that referenced this issue Sep 3, 2024
@jciasenza
Copy link

i have made PR #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants