Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: Optimizely support #387

Closed
1 task
MaxFrank13 opened this issue Jul 16, 2024 · 1 comment
Closed
1 task

[DEPR]: Optimizely support #387

MaxFrank13 opened this issue Jul 16, 2024 · 1 comment
Assignees
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@MaxFrank13
Copy link
Member

MaxFrank13 commented Jul 16, 2024

Proposal Date

2024-07-16

Target Ticket Acceptance Date

2024-07-26

Earliest Open edX Named Release Without This Functionality

Sumac - 2024-10

Rationale

Optimizely is a package used for running experiments. It is not a required dependency of the MFE and there is no out-of-the-box support for Optimizely in the Open edX frontend ecosystem. It is was originally added for a 2U-specific use case and does not appear to be used by any other consumers.

Removal

Components

Pull Request

#386

Replacement

ProductRecommendations, WidgetFooter, ExperimentContext, optimizelyScript, and the Optimizely dependency will have no replacement.

The LoadedSidebar and NoCoursesSidebar components will be condensed into one WidgetSidebar component. This WidgetSidebar component will be set to render next to the CoursesPanel by default, whereas previously it appeared to be set underneath by default. However, it was actually being re-set to be next to the CoursesPanel by the WidgetFooter component (source). Additional context below.

Deprecation

No response

Migration

No response

Additional Info

@MaxFrank13

Context around WidgetSidebar/LoadedSidebar/NoCoursesSidebar

The position of the LoadedSidebar or NoCoursesSidebar is determined by the sidebarShowing state. If set to true, the sidebar will appear next to the CoursesPanel in the Dashboard. Otherwise, it will render underneath the CoursesPanel. Currently this value is only switched to true inside either the LoadedSidebar or NoCoursesSidebar components. The Sidebar component will check the ExperimentContext to see if isExperimentActive is set to true. The redundancy here arises when we realize that isExperimentActive will always be true, because of the hook call in WidgetFooter.

Since the deprecation requires removing the hook that "activates the experiment" and any references to the values in ExperimentContext, we can instead have the sidebar set to show next to the CoursesPanel by default (sidebarShowing set to true). This also supports future development for the sidebar.

Task List

@github-actions github-actions bot added the depr Proposal for deprecation & removal per OEP-21 label Jul 16, 2024
@MaxFrank13 MaxFrank13 self-assigned this Jul 16, 2024
@deborahgu deborahgu moved this to Backlog in Aperture-Maintained Jul 16, 2024
@deborahgu deborahgu added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Jul 16, 2024
@MaxFrank13 MaxFrank13 moved this from Backlog to In Progress in Aperture-Maintained Jul 22, 2024
@MaxFrank13
Copy link
Member Author

The PR has been approved and will be merged today. This seems safe given that there was no objection or discussion in the forum thread or this issue.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Aperture-Maintained Aug 8, 2024
@github-project-automation github-project-automation bot moved this from Proposed to Removed in DEPR: Deprecation & Removal Aug 8, 2024
@MaxFrank13 MaxFrank13 removed the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Status: Done
Status: Removed
Development

No branches or pull requests

2 participants