Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show help button if no support page is configured #373

Open
arbrandes opened this issue Jul 5, 2024 · 1 comment
Open

Don't show help button if no support page is configured #373

arbrandes opened this issue Jul 5, 2024 · 1 comment
Labels
bug Report of or fix for something that isn't working as intended
Milestone

Comments

@arbrandes
Copy link
Contributor

Description

On a bare installation one sees the Help button even though no support page exists:

image

The result is a 404 if you click it.

Expected behavior

If no support page is configured, the Help button should simply not show.

Implementation

Since an MFE config variable already exists, we can simply check to see if it's populated before rendering.

@arbrandes arbrandes added the bug Report of or fix for something that isn't working as intended label Jul 5, 2024
@arbrandes arbrandes moved this to Backlog in Frontend Working Group Jul 5, 2024
@arbrandes arbrandes added this to the Redwood.2 milestone Jul 5, 2024
@deborahgu deborahgu moved this to Open Source Community in Aperture-Maintained Jul 12, 2024
@lkatsikaris
Copy link

I can take this issue @arbrandes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Help Wanted
Status: Backlog
2 participants