Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility of frontend-app-learner-dashboard with @edx/brand theming style #350

Closed
httpsmenahassan opened this issue Oct 12, 2023 · 1 comment
Assignees

Comments

@httpsmenahassan
Copy link
Contributor

I tested frontend-app-learner-dashboard using the openedx brand theme and the style changes looked great. Nothing stuck out to me as a concern.

Here's the MFE with the openedx brand:
localhost_1996

And here is it with edx.org brand. (default at the moment: #183)
localhost_1997

Changes noticed when using openedx brand

  • the header seems like it's doing the right things
    • the following items change from a more rounded appearance to a more straight lined appearance
      • the line below courses
      • the avatar button edges
      • view as: bar and submit buttons
    • there's also shading above and below the view as bars and submit button
  • 'submit' button changes color from a purple-y to a muted red (overlay look)
  • 'My Courses'/'Looking for a new challenge?'/'Explore our courses to add them to your dashboard.' - font weight and decreases and become a lighter black/dark gray
  • 'Refine' button loses it's border and has overlay appearance
  • 'Explore courses' button changes from rounded edges to sharp corners and the button color changes from a magenta purple to red
  • 'Find a course' color change
@httpsmenahassan httpsmenahassan self-assigned this Oct 12, 2023
@kdmccormick kdmccormick transferred this issue from openedx/axim-engineering May 13, 2024
@kdmccormick
Copy link
Member

@brian-smith-tcril , looks like Mena did a spike here, and the result is that everything looks good? Gonna close, feel free to repoen if you think there are action items.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Axim Engineering Tasks May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants