-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted grades should not greater than 100% #394
Comments
Hi @mariajgrimaldi ! I tried this on a local branch and fixed it by comparing the value of the input with the possibleGrade (the maximum grade can take) and enabling the save button only if the value is minor than the possibleGrade (line 66). Previously, I had to modify the useAdjustedGradeInputData hook to return the possible grade that we need in the comparison above, like this: |
Hey, @lkatsikaris, thank you so much for trying that out! @jmakowski1123 @crathbun428: this is an enhancement for the grading configuration studio page. Could you review it from the product side? Let us know! |
I created PR #402 |
Thank you, @lkatsikaris! |
Setting this as the max makes sense to me! I imagine some people might want to allow for over 100% grades, but it seems reasonable to make this the default IMO. |
Expected behavior
There should be a validation check that the value is not greater than 100%, and it should show the updated value.
Actual behavior
Incorrect value and validation is missing
Steps to reproduce
Additional information
Original issue: openedx/wg-build-test-release#357
The text was updated successfully, but these errors were encountered: