Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted grades should not greater than 100% #394

Open
mariajgrimaldi opened this issue May 23, 2024 · 5 comments · May be fixed by #402
Open

Adjusted grades should not greater than 100% #394

mariajgrimaldi opened this issue May 23, 2024 · 5 comments · May be fixed by #402
Labels
enhancement Relates to new features or improvements to existing features release testing Affects the upcoming release (attention needed)

Comments

@mariajgrimaldi
Copy link
Member

Expected behavior

There should be a validation check that the value is not greater than 100%, and it should show the updated value.

Actual behavior

Incorrect value and validation is missing

Steps to reproduce

  1. Go to instructor's tab of a course with staff access
  2. Go to student admin tab
  3. click on view gradebook button
  4. update student's grade to 99 and check if its updated correctly.

Additional information

Screenshot 2024-05-22 at 1 19 02 PM Screenshot 2024-05-22 at 1 19 15 PM Screenshot 2024-05-22 at 1 21 37 PM

Original issue: openedx/wg-build-test-release#357

@mariajgrimaldi mariajgrimaldi added the release testing Affects the upcoming release (attention needed) label May 23, 2024
@mariajgrimaldi mariajgrimaldi added the enhancement Relates to new features or improvements to existing features label May 24, 2024
@lkatsikaris
Copy link

lkatsikaris commented Aug 14, 2024

Hi @mariajgrimaldi ! I tried this on a local branch and fixed it by comparing the value of the input with the possibleGrade (the maximum grade can take) and enabling the save button only if the value is minor than the possibleGrade (line 66).

image

Previously, I had to modify the useAdjustedGradeInputData hook to return the possible grade that we need in the comparison above, like this:

image

image

@mariajgrimaldi
Copy link
Member Author

Hey, @lkatsikaris, thank you so much for trying that out! @jmakowski1123 @crathbun428: this is an enhancement for the grading configuration studio page. Could you review it from the product side? Let us know!

@lkatsikaris
Copy link

I created PR #402

@lkatsikaris lkatsikaris linked a pull request Aug 27, 2024 that will close this issue
6 tasks
@mariajgrimaldi
Copy link
Member Author

Thank you, @lkatsikaris!

@mariajgrimaldi mariajgrimaldi moved this from Backlog to In progress in Build-Test-Release Working Group Sep 16, 2024
@marcotuts
Copy link

Setting this as the max makes sense to me! I imagine some people might want to allow for over 100% grades, but it seems reasonable to make this the default IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Relates to new features or improvements to existing features release testing Affects the upcoming release (attention needed)
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants