Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course import not working #982

Closed
jmakowski1123 opened this issue May 6, 2024 · 5 comments
Closed

Course import not working #982

jmakowski1123 opened this issue May 6, 2024 · 5 comments
Assignees
Labels
release testing Affects the upcoming release (attention needed)

Comments

@jmakowski1123
Copy link

Importing a tar file does not work, it gets stuck on the first step and just spins.

course.cjycyzl5.tar.gz

^Sample tar file attempting to upload

Screen Shot 2024-05-06 at 3 02 24 PM
@jmakowski1123 jmakowski1123 added the release testing Affects the upcoming release (attention needed) label May 6, 2024
@ormsbee
Copy link
Contributor

ormsbee commented May 7, 2024

This looks like a CORS configuration issue. Digging into the details...

@ormsbee ormsbee self-assigned this May 7, 2024
@ormsbee
Copy link
Contributor

ormsbee commented May 7, 2024

Oh, this probably doesn't manifest on devstack because everything is served from localhost, as opposed to Tutor where things are served on different domains.

@ormsbee
Copy link
Contributor

ormsbee commented May 8, 2024

Okay, so the root issue is that we need to add content-range and content-disposition to Studio's CORS_ALLOW_HEADERS setting...

But this is organized in a weird way. It's declared redundantly in three places instead of inheriting from common, and then the value for edx-platform is completely ignored by Tutor, which does its own thing. I think the right thing to do here is to make it so that CORS_ALLOW_HEADERS is defined only in the common.py file, since it shouldn't depend on the environment it's deployed in (unlike most of the other CORS settings).

@ormsbee
Copy link
Contributor

ormsbee commented May 8, 2024

This should be fixed by the combination of:

It should get deployed in tomorrow morning's build.

@ormsbee
Copy link
Contributor

ormsbee commented May 9, 2024

Verified fix on the next-release sandbox.

@ormsbee ormsbee closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release testing Affects the upcoming release (attention needed)
Projects
None yet
Development

No branches or pull requests

2 participants