Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Config Page - location counts not displaying #981

Closed
jmakowski1123 opened this issue May 6, 2024 · 2 comments · Fixed by #991
Closed

Group Config Page - location counts not displaying #981

jmakowski1123 opened this issue May 6, 2024 · 2 comments · Fixed by #991
Assignees
Labels
release testing Affects the upcoming release (attention needed)

Comments

@jmakowski1123
Copy link

In the legacy page, the content groups contain counts of how many locations they are used in:

Screen Shot 2024-05-06 at 2 45 50 PM

In the MFE page, the number for the counts is missing

Screen Shot 2024-05-06 at 2 46 26 PM
@jmakowski1123 jmakowski1123 added the release testing Affects the upcoming release (attention needed) label May 6, 2024
@ruzniaievdm
Copy link
Contributor

Indeed, in the previous implementation we used counters, as well as the legacy version.
At the code review stage, was proposed an approach without counters. Reference: #929 (comment)
@KristinAoki Could you please tell me if this is true and if we should continue to use the approach without counters?

@KristinAoki
Copy link
Member

KristinAoki commented May 8, 2024

@ruzniaievdm That was an error on my part. I forgot to also include the counter in my suggested change. I will leave a comment on #929 comment that includes the counter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release testing Affects the upcoming release (attention needed)
Projects
None yet
4 participants