Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove pointless maintenance link message #1503

Merged

Conversation

kdmccormick
Copy link
Member

This link is defined in frontend-component-header, so the message shouldn't be here. Anyway, we are deleting the link from frontend-component-header too, as the app is being removed from edx-platform.

This link is defined in frontend-component-header, so the message
shouldn't be here. Anyway, we are deleting the link from
frontend-component-header too.
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (d99e3f0) to head (d76411c).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1503      +/-   ##
==========================================
- Coverage   93.28%   93.02%   -0.26%     
==========================================
  Files        1052     1048       -4     
  Lines       20503    20493      -10     
  Branches     4385     4406      +21     
==========================================
- Hits        19126    19064      -62     
- Misses       1317     1359      +42     
- Partials       60       70      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kdmccormick
Copy link
Member Author

Codecov failure is unrelated to this change

@kdmccormick kdmccormick merged commit 6ffdb01 into openedx:master Nov 15, 2024
6 of 7 checks passed
@kdmccormick kdmccormick deleted the kdmccormick/cms-maintenance-depr branch November 15, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants