Skip to content

Commit

Permalink
test: increase test coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
bradenmacdonald committed May 8, 2024
1 parent 29daee5 commit e82c2de
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/generic/data/apiHooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ export const useStudioHomeData = () => useQuery({

/**
* Are the tagging/taxonomy features enabled?
*
* TODO: This is temporary, for the Open edX Redwood release. Sometime post-Redwood pre-Sumac (and after being enabled
* for a while on edx.org), this should be removed and the tagging/taxonomy functionality always enabled.
*
* @returns {boolean} Whether they are enabled (default true)
*/
export const useTaggingFeaturesEnabled = () => {
Expand Down
13 changes: 13 additions & 0 deletions src/taxonomy/taxonomy-detail/TaxonomyDetailPage.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import TaxonomyDetailPage from './TaxonomyDetailPage';
let store;
const mockNavigate = jest.fn();
const mockMutate = jest.fn();
const mockTaggingFeaturesEnabled = jest.fn();
let axiosMock;

jest.mock('react-router-dom', () => ({
Expand All @@ -21,11 +22,16 @@ jest.mock('react-router-dom', () => ({
taxonomyId: '1',
}),
useNavigate: () => mockNavigate,
Navigate: jest.fn(({ to }) => `[Navigate: Redirected to ${to}]`),
}));
jest.mock('../data/apiHooks', () => ({
...jest.requireActual('../data/apiHooks'),
useDeleteTaxonomy: () => mockMutate,
}));
jest.mock('../../generic/data/apiHooks', () => ({
...jest.requireActual('../../generic/data/apiHooks'),
useTaggingFeaturesEnabled: () => mockTaggingFeaturesEnabled(),
}));

jest.mock('./TaxonomyDetailSideCard', () => jest.fn(() => <>Mock TaxonomyDetailSideCard</>));
jest.mock('../tag-list/TagListTable', () => jest.fn(() => <>Mock TagListTable</>));
Expand Down Expand Up @@ -54,6 +60,7 @@ describe('<TaxonomyDetailPage />', () => {
});
store = initializeStore();
axiosMock = new MockAdapter(getAuthenticatedHttpClient());
mockTaggingFeaturesEnabled.mockReturnValue(true);
});

afterEach(() => {
Expand All @@ -62,6 +69,12 @@ describe('<TaxonomyDetailPage />', () => {
queryClient.clear();
});

it('redirects to Studio home if the tagging feature is disabled', () => {
mockTaggingFeaturesEnabled.mockReturnValue(false);
const doc = render(<RootWrapper />);
expect(doc.asFragment().textContent).toEqual('[Navigate: Redirected to /home]');
});

it('shows the spinner before the query is complete', () => {
// Use unresolved promise to keep the Loading visible
axiosMock.onGet(apiUrls.taxonomy(1)).reply(() => new Promise());
Expand Down

0 comments on commit e82c2de

Please sign in to comment.