fix: Updated copy change on Name Change modal #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 58.61% 58.61%
=======================================
Files 117 117
Lines 2317 2317
Branches 641 644 +3
=======================================
Hits 1358 1358
Misses 898 898
Partials 61 61 ☔ View full report in Codecov by Sentry. |
Zacharis278
approved these changes
Aug 21, 2024
MichaelRoytman
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
This looks good to me - agree with Zach about the duplicate.
Could you link to the openedx/platform-roadmap#367 issue in your pull request description, briefly explain that we are doing this to generalize the copy, and request the Infinity team for a review, please?
rijuma
force-pushed
the
rijuma/verify-copy-change
branch
from
b1bdad7
to
11d7d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just a copy change on the Name Change modal. This is part of the New IDV vendor work openedx/platform-roadmap#367.
Old copy:
New copy:
How Has This Been Tested?
Tested locally.
Post-merge Checklist