Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove support for Node 18 #1112

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Sep 2, 2024

Note: As per openedx/public-engineering#280 this can merge after Sumac cut.

Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using .nvmrc for version to use.

See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Sep 2, 2024
@BilalQamar95 BilalQamar95 mentioned this pull request Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.61%. Comparing base (4136a63) to head (8576f7a).
Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1112   +/-   ##
=======================================
  Coverage   58.61%   58.61%           
=======================================
  Files         117      117           
  Lines        2317     2317           
  Branches      639      641    +2     
=======================================
  Hits         1358     1358           
  Misses        898      898           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril merged commit 3022a26 into master Oct 31, 2024
8 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node20-upgrade-3 branch October 31, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants