Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: long email field on account page #1024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bydawen
Copy link

@bydawen bydawen commented Apr 2, 2024

Similar PR is opened to the open-release/quince branch:
#1025

Fix for the long email field to prevent page break for the mobile view:

If user has a long type email it will be overlap from content of page:
1
11

After fix:
2
22

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 2, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 2, 2024

Thanks for the pull request, @bydawen!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/edx-infinity. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 2, 2024
@e0d
Copy link

e0d commented Apr 5, 2024

@bydawen I've invited you the triage team which will allow tests to run automatically in the future, please accept that invite when you receive it.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.79%. Comparing base (feef40f) to head (e0bcece).
Report is 85 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1024   +/-   ##
=======================================
  Coverage   56.79%   56.79%           
=======================================
  Files         119      119           
  Lines        2495     2495           
  Branches      673      673           
=======================================
  Hits         1417     1417           
  Misses       1004     1004           
  Partials       74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Apr 5, 2024
@mphilbrick211
Copy link

Hi @openedx/2u-aperture! This, along with its backport, are ready for review.

@justinhynes
Copy link
Contributor

Hi @mphilbrick211 Apologies for the delay. I am under the impression that the @openedx/2u-vanguards will be the maintainers of the Account MFE moving forward.

@mphilbrick211
Copy link

Hi @hurtstotouchfire - can you confirm if Aperture will be maintaining this repo?

@mphilbrick211
Copy link

Hi @openedx/2u-vanguards! This is ready for review along with its backport. Thanks!

@mphilbrick211 mphilbrick211 added needs reviewer assigned PR needs to be (re-)assigned a new reviewer and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Jul 30, 2024
@ihor-romaniuk
Copy link
Contributor

@mphilbrick211 @openedx/2u-vanguards It seems like it is ready for review and merge. Could we speed it up, please?

@mphilbrick211
Copy link

mphilbrick211 commented Sep 6, 2024

Hi @openedx/2u-vanguards - are you still maintaining this repo? If so, could you please give this a look? Thanks! (cc: @openedx/edx-infinity)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

6 participants