-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove bok-choy #1165
chore: remove bok-choy #1165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also drop the dependency on selenium but then I think this is good to merge.
requirements/test.txt
Outdated
# via requests | ||
# via | ||
# requests | ||
# selenium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like anything else is using selenium either, so it's probably safe to remove that from test.in
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil should i remove the selenium under the scope of this PR? or create separate one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove selenium along with bok-choy if it's not being used independently of bok-choy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil done.
Starting with
with
|
50d01c0
to
5f446f2
Compare
Description:
As the bok-choy has been deprecated openedx/public-engineering#13, we are removing its usage from the code in this PR.
Ticket : https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=43871891