Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add First Purchase Discount override #35143

Merged

Conversation

julianajlk
Copy link
Contributor

@julianajlk julianajlk commented Jul 19, 2024

REV-4098.

Adding the logic to modify the offer data in Course Home API to be able to be overriden if the waffle flag is enabled to another First Purchase Discount code.

This offer data is used by Learning MFE to display the upgrade notification message with a discount code.

@julianajlk julianajlk force-pushed the julianajlk/REV-4098/fpd-edxwelcome-override-offer-data branch 2 times, most recently from 1283789 to 33b91cb Compare July 19, 2024 13:58
Copy link
Contributor

@christopappas christopappas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one typo in the comment, other than that LGTM

lms/envs/test.py Outdated Show resolved Hide resolved
@julianajlk julianajlk force-pushed the julianajlk/REV-4098/fpd-edxwelcome-override-offer-data branch from 05fc720 to b021e75 Compare July 22, 2024 16:08
@julianajlk julianajlk merged commit a196977 into master Jul 22, 2024
49 checks passed
@julianajlk julianajlk deleted the julianajlk/REV-4098/fpd-edxwelcome-override-offer-data branch July 22, 2024 18:01
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

mudassir-hafeez pushed a commit to mudassir-hafeez/edx-platform that referenced this pull request Jul 24, 2024
mudassir-hafeez pushed a commit to mudassir-hafeez/edx-platform that referenced this pull request Jul 24, 2024
mudassir-hafeez pushed a commit to mudassir-hafeez/edx-platform that referenced this pull request Jul 24, 2024
mudassir-hafeez pushed a commit to mudassir-hafeez/edx-platform that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants