Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrading api list_course_role_members ( 2nd api ) #35105

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Jul 10, 2024

Issue for tracking.

Updating api code using DRF.

  1. Added standard authentication_classes
  2. Added permission_classes

Steps to verify on local tutor instance:

  1. Open this page and few data-research roles.
  2. Go to this page and go to the bottom of page.
  3. From dropdown select the Course Data Researcher.

Expected result:

{
  "course_id": "course-v1:edx+cs222+2311",
  "data_researcher": [
    {
      "username": "admin",
      "email": "[email protected]",
      "first_name": "abc",
      "last_name": "qdd"
    },
    {
      "username": "login_service_user",
      "email": "[email protected]",
      "first_name": "",
      "last_name": ""
    }
  ]
}
  • Verified on local via instructor dashboard and also from postman.
Screenshot 2024-07-30 at 8 38 33 PM

@awais786 awais786 changed the title Upgrading api3 Upgrading api list_course_role_members Jul 11, 2024
@awais786 awais786 changed the title Upgrading api list_course_role_members feat: 3rd Upgrading api list_course_role_members Jul 19, 2024
@awais786 awais786 changed the title feat: 3rd Upgrading api list_course_role_members feat: Upgrading api list_course_role_members ( 2nd api ) Jul 30, 2024
@awais786 awais786 requested a review from feanil July 30, 2024 15:37
@awais786 awais786 marked this pull request as ready for review July 30, 2024 18:43
Comment on lines 1088 to 1091
authentication_classes = (
JwtAuthentication,
BearerAuthenticationAllowInactiveUser,
SessionAuthenticationAllowInactiveUser,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add this explicitly, this is the default for edx-platform. You should remove these lines.

Copy link
Contributor

@iamsobanjaved iamsobanjaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awais786 awais786 merged commit 99760f8 into master Aug 7, 2024
50 checks passed
@awais786 awais786 deleted the upgrading-api3 branch August 7, 2024 11:40
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Agrendalath pushed a commit to open-craft/edx-platform that referenced this pull request Oct 22, 2024
* feat: upgrading simple api to drf compatible.

(cherry picked from commit 99760f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants