-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrading api list_course_role_members ( 2nd api ) #35105
Conversation
authentication_classes = ( | ||
JwtAuthentication, | ||
BearerAuthenticationAllowInactiveUser, | ||
SessionAuthenticationAllowInactiveUser, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to add this explicitly, this is the default for edx-platform. You should remove these lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
* feat: upgrading simple api to drf compatible. (cherry picked from commit 99760f8)
Issue for tracking.
Updating api code using DRF.
Steps to verify on local tutor instance:
Course Data Researcher
.Expected result: