Remove MongoDBProxy and Migrate to Native PyMongo Retry Functionality #35213
Conversation
|
Thanks for the pull request, @yashathwani! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
There was a problem hiding this comment.
Thanks for the quick PR @yashathwani !
In addition to the comments below, you'll need to reword your commit as a conventional commit. In your case you could simply do refactor: Replace MongoDBProxy usage with direct pymongo.MongoClient configuration
Lastly, please sign the CLA if you have not already: https://openedx.org/cla
| @@ -66,14 +65,6 @@ def connect_to_mongodb( | |||
| connection_params.update({'username': user, 'password': password, 'authSource': db}) | |||
|
|
|||
| mongo_conn = pymongo.MongoClient(**connection_params) | |||
|
|
|||
| if proxy: | |||
There was a problem hiding this comment.
Since proxy is now unused, could you remove it from the parameters list and the docstring for this method?
| # Assert that retries are handled correctly | ||
| self.assertGreater(mock_database.admin.command.call_count, 1) # Ensure retries happened |
There was a problem hiding this comment.
Nice, thanks for testing this.
| @@ -12,7 +12,7 @@ | |||
| from bson.son import SON | |||
| from fs.osfs import OSFS | |||
| from gridfs.errors import NoFile, FileExists | |||
| from mongodb_proxy import autoretry_read | |||
|
|
|||
There was a problem hiding this comment.
to satisfy pycodestyle, you'll need to remove these now-empty lines
|
@yashathwani this is a really valuable PR, I hope you're still interested in getting it merged. Let me know if there is any way I can help with the CLA or with getting CI to pass. |
|
@yashathwani , do you plan on finishing this PR? |
|
@mphilbrick211 do you know what state this contributor's CLA is in? |
Inspired by openedx#35213 Closes openedx#35210 Co-Authored-By: Yash Athwani <[email protected]>
|
Hi @yashathwani , since we have not heard from you, I have opened a new iteration of this PR: #35556 |
Description
This pull request removes the custom MongoDBProxy package from the edx-platform and updates the codebase to use PyMongo's built-in retryable reads and writes features. This change is intended to simplify the codebase by eliminating the need for the custom package and leveraging the native support provided by recent versions of PyMongo.
Impact on User Roles:
Developer: Developers will no longer need to maintain the MongoDBProxy package and will use PyMongo's built-in features for retries.
Operator: Operators will benefit from a more streamlined and supported connection handling process.
Resolves #35210