Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MongoDBProxy #35210

Open
3 tasks
kdmccormick opened this issue Jul 31, 2024 · 5 comments
Open
3 tasks

Remove MongoDBProxy #35210

kdmccormick opened this issue Jul 31, 2024 · 5 comments
Assignees
@kdmccormick @yashathwani
Labels
code health Proactive technical investment via refactorings, removals, etc. good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Jul 31, 2024 •
edited
Loading

We install a fork of MongoDBPRoxy and use it in edx-platform (search for mongodb_proxy). The package is extremely simple -- it just makes is so that pymongo automatically retries certain queries N times.

I hear that this feature is now baked into Mongo and/or pymongo. If we can take advantage of that builtin feature, it would be great to remove this custom mongodb_proxy package from edx-platform and archive the repo so that we don't have maintain it anymore.

Acceptance Criteria

  • Confirm that the functionality of mongodb_proxy can be recreated using builtin mongo features
  • Switch edx-platform to use the builtin mongo retry feature, and uninstall mongodbproxy from edx-platform
  • File an Axim Systems Request, asking that MongoDBProxy be archived.
@kdmccormick kdmccormick added code health Proactive technical investment via refactorings, removals, etc. help wanted Ready to be picked up by anyone in the community good first issue A good task for a newcomer to start with labels Jul 31, 2024
@yashathwani
Copy link

I would like to work on this issue. Could you please assign it to me?

@kdmccormick
Copy link
Member Author

Thanks @yashathwani !

@yashathwani yashathwani mentioned this issue Aug 1, 2024
Closed
@yashathwani
Copy link

@kdmccormick Could you please review the pull request and, if everything is in order, merge it? Your verification and feedback would be greatly appreciated.

@kdmccormick
Copy link
Member Author

Will review, thank you @yashathwani !

kdmccormick added a commit to kdmccormick/edx-platform that referenced this issue Sep 27, 2024
@kdmccormick @yashathwani
refactor: replace MongoDBProxy usage with direct pymongo config
5e139ce 
Inspired by openedx#35213

Closes openedx#35210

Co-Authored-By: Yash Athwani <[email protected]>
@kdmccormick kdmccormick mentioned this issue Sep 27, 2024
Draft
@kdmccormick kdmccormick self-assigned this Sep 27, 2024
@kdmccormick
Copy link
Member Author

New PR: #35556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdmccormick kdmccormick

@yashathwani yashathwani

Labels
code health Proactive technical investment via refactorings, removals, etc. good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove MongoDBProxy and Migrate to Native PyMongo Retry Functionality yashathwani/edx-platform
2 participants
@kdmccormick @yashathwani