feat: Add override on percentage config to the First Purchase Discount #35167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianajlk
force-pushed
the
julianajlk/REV-4098/fpd-edxwelcome-override-percentage
branch
2 times, most recently
from
b58935d
to
47415ed
Compare
christopappas
approved these changes
Jul 23, 2024
julianajlk
force-pushed
the
julianajlk/REV-4098/fpd-edxwelcome-override-percentage
branch
from
1820a85
to
573c6fc
Compare
julianajlk
force-pushed
the
julianajlk/REV-4098/fpd-edxwelcome-override-percentage
branch
from
573c6fc
to
43157a5
Compare
julianajlk
deleted the
julianajlk/REV-4098/fpd-edxwelcome-override-percentage
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REV-4098.
There is a previously added
DiscountPercentageConfigthat would allow us to change the percentage displayed for the First Purchase Discount via Django Admin. However, this is controlled in app-permissions, which as been broken for several weeks, and none of the current Purchase squad members have the ability to see this config (it's also not added in the discounts_admin group).Adding an override via waffle flag for the displayed percentage instead.