fix: downgrade django-storages to 1.14.3 #35156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayzhou-bit
approved these changes
Jul 23, 2024
jristau1984
approved these changes
Jul 23, 2024
jristau1984
approved these changes
Jul 23, 2024
Commit generated by workflow `openedx/edx-platform/.github/workflows/compile-python-requirements.yml@refs/heads/master` Co-authored-by: KristinAoki <[email protected]>
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
feanil
reviewed
Jul 23, 2024
|
|
||
| # django-storages==1.14.4 breaks course imports | ||
| # Two lines were added in 1.14.4 that make file_exists_in_storage function always return False, | ||
| # as the default value of AWS_S3_FILE_OVERWRITE is True |
There was a problem hiding this comment.
@KristinAoki @jristau1984 please create a github issue for removing this constraint in the future and ideally schedule that for a future sprint.
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
* fix: downgrade django-storages to 1.14.3 * fix: change max version * feat: Recompile Python dependencies (openedx#35164) Commit generated by workflow `openedx/edx-platform/.github/workflows/compile-python-requirements.yml@refs/heads/master` Co-authored-by: KristinAoki <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
* fix: downgrade django-storages to 1.14.3 * fix: change max version * feat: Recompile Python dependencies (openedx#35164) Commit generated by workflow `openedx/edx-platform/.github/workflows/compile-python-requirements.yml@refs/heads/master` Co-authored-by: KristinAoki <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
* fix: downgrade django-storages to 1.14.3 * fix: change max version * feat: Recompile Python dependencies (openedx#35164) Commit generated by workflow `openedx/edx-platform/.github/workflows/compile-python-requirements.yml@refs/heads/master` Co-authored-by: KristinAoki <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mudassir-hafeez
pushed a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
* fix: downgrade django-storages to 1.14.3 * fix: change max version * feat: Recompile Python dependencies (openedx#35164) Commit generated by workflow `openedx/edx-platform/.github/workflows/compile-python-requirements.yml@refs/heads/master` Co-authored-by: KristinAoki <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent upgrade to
django-storagesfrom1.14.3to1.14.4broke the ability to import a course. The course was able to upload but after uploading the file was not able to be found when the import moved to the "Unpacking" step. This change impacts the "Developer" and "Authors".This bug was introduced in #35125.
Supporting information
Testing instructions