Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styles for share video functionality of the video xblock #34808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented May 16, 2024

Description

This pull request contains styling fixes for the Share this video functionality for LMS and CMS. Hardcoded styles were also removed and a link to platform brand styles/colors was added.

Related Pull Requests

PR to the open-release/quince.master branch: #34810
PR to the open-release/redwood.master branch: #34893

Screenshots before:

LMS image LMS image CMS image CMS image

Screenshots after:

LMS image LMS image CMS image CMS image

Steps to Reproduce:

  1. Enable new video editor and sharing by adding in /admin/waffle/flag/
  • video_config.public_video_share
  • new_core_editors.use_new_video_editor
  1. In studio open unit -> add new component -> video -> in Social Sharing block enable check-box, save
  2. Open unit in LMS

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 16, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 16, 2024

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211
Copy link

Hi @ihor-romaniuk! This should get reviewed by Product.

Flagging for @jmakowski1123!

@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label May 20, 2024
@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/fix-styles-for-share-video-functionality-of-the-video-xblock branch from f204d92 to 552fb3a Compare September 3, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Status: Product Review
Development

Successfully merging this pull request may close these issues.

3 participants