feat: purge name from certificate records during learner retirement #34799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinhynes
commented
May 14, 2024
justinhynes
commented
May 14, 2024
Comment on lines
-1485
to
1527
| def _data_sharing_consent_assertions(self): | ||
| """ | ||
| Helper method for asserting that ``DataSharingConsent`` objects are retired. | ||
| """ | ||
| self.consent.refresh_from_db() | ||
| assert self.retired_username == self.consent.username | ||
| test_users_data_sharing_consent = DataSharingConsent.objects.filter( | ||
| username=self.original_username | ||
| ) | ||
| assert not test_users_data_sharing_consent.exists() | ||
|
|
||
| def test_can_retire_users_sap_success_factors_audits(self): |
There was a problem hiding this comment.
Moved these verification functions to the top of the file. Generally, I get confused when helper and assertion functions are mixed in with all the tests.
I try to keep things like this:
- setUp/tearDown functions
- helper and assert/verification functions
- test cases
If y'all think I'm being too particular, let me know.
justinhynes
commented
May 14, 2024
justinhynes
force-pushed
the
jhynes/APER-3241_purge-leftover-pii-from-certificate-records
branch
3 times, most recently
from
3c8bf14
to
d5561f9
Compare
deborahgu
reviewed
May 15, 2024
lms/djangoapps/certificates/management/commands/purge_pii_from_generatedcertificates.py
Outdated
Show resolved
Hide resolved
deborahgu
requested changes
May 15, 2024
| (like the Credentials IDA). | ||
|
|
||
| This management command functions by requesting a list of learners' user_ids whom have completed their journey | ||
| through the retirement pipeline. The `get_retired_user_ids` utility function is responsible for removing any |
There was a problem hiding this comment.
Suggested change
| through the retirement pipeline. The `get_retired_user_ids` utility function is responsible for removing any | |
| through the retirement pipeline. The `get_retired_user_ids` utility function is responsible for filtering out any |
because "removing" is ambiguous in this context.
lms/djangoapps/certificates/management/commands/purge_pii_from_generatedcertificates.py
Outdated
Show resolved
Hide resolved
...angoapps/certificates/management/commands/tests/test_purge_pii_from_generatedcertificates.py
Outdated
Show resolved
Hide resolved
...angoapps/certificates/management/commands/tests/test_purge_pii_from_generatedcertificates.py
Outdated
Show resolved
Hide resolved
...angoapps/certificates/management/commands/tests/test_purge_pii_from_generatedcertificates.py
Show resolved
Hide resolved
...angoapps/certificates/management/commands/tests/test_purge_pii_from_generatedcertificates.py
Show resolved
Hide resolved
openedx/core/djangoapps/user_api/accounts/tests/test_retirement_views.py
Outdated
Show resolved
Hide resolved
lms/djangoapps/certificates/management/commands/purge_pii_from_generatedcertificates.py
Outdated
Show resolved
Hide resolved
[APER-3241] This PR updates the retirement pipeline to purge learners' names from certificate records when their account is being retired. It also introduces a new management command that can be used by Open edX operators to purge the leftover name data (PII data) from the `certificates_generatedcertificate` table. This is designed as a one-time use data fixup, as the retirement functionality should clean this up now.
justinhynes
force-pushed
the
jhynes/APER-3241_purge-leftover-pii-from-certificate-records
branch
from
59de534
to
fd805e0
Compare
justinhynes
deleted the
jhynes/APER-3241_purge-leftover-pii-from-certificate-records
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[APER-3241]
This PR updates the retirement pipeline to purge learners' names from certificate records when their account is being retired.
It also introduces a new management command that can be used by Open edX operators to purge the leftover name data (PII data) from the
certificates_generatedcertificatetable. This is designed as a one-time use data fixup, as the retirement functionality should clean this up now.