feanil/python311 reqs #34788
Merged
feanil/python311 reqs #34788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kdmccormick
approved these changes
May 13, 2024
There was a problem hiding this comment.
approving under the assumption that you're just splitting up #34780 into smaller PRs
|
We'll come back to this after Wednesday May 22. |
feanil
force-pushed
the
feanil/python311_reqs
branch
from
fa92990
to
8fb41a9
Compare
feanil
force-pushed
the
feanil/python311_reqs
branch
from
49606e8
to
87937e7
Compare
feanil
force-pushed
the
feanil/python311_reqs
branch
from
87937e7
to
538d8fb
Compare
This was being pulled in as a transitive dependency before but it turns out we need this directly for the usage in openedx/core/djangoapps/plugins/i18n_api.py We add it to kernel.in before re-building the requirements files.
Previously the default for the `keepdims` parameter was True, but as of SciPy 1.11.0 it is false. This is actually the behavior we want here since we only care about the mode value and not other values. https://docs.scipy.org/doc/scipy/release/1.11.0-notes.html#expired-deprecations
feanil
force-pushed
the
feanil/python311_reqs
branch
from
538d8fb
to
623061f
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
timmc-edx
added a commit
that referenced
this pull request
Jun 12, 2024
PR #34788 upgraded some Python dependencies that require Python > 3.8, so we also need to upgrade the Python version used in the Docker images.
kdmccormick
added a commit
to kdmccormick/openedx-scorm-xblock
that referenced
this pull request
Jun 25, 2024
1. importlib_resources is a backport of.... 2. importlib.resources, a standard library package Redwood and earlier installed (1). Starting with the [py3.11 upgrade] we dropped (1) in favor of (2). To maintain compatibility with both, we use a try-except. Fixes the error on Tutor Nightly: ModuleNotFoundError: No module named 'importlib_resources' [py3.11 upgrade] openedx/edx-platform#34788
ziafazal
pushed a commit
to overhangio/openedx-scorm-xblock
that referenced
this pull request
Jun 27, 2024
1. importlib_resources is a backport of.... 2. importlib.resources, a standard library package Redwood and earlier installed (1). Starting with the [py3.11 upgrade] we dropped (1) in favor of (2). To maintain compatibility with both, we use a try-except. Fixes the error on Tutor Nightly: ModuleNotFoundError: No module named 'importlib_resources' [py3.11 upgrade] openedx/edx-platform#34788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make upgardewith Python 3.11make upgrade